-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When GDScript LSP is active, it reports issues on other filetypes (e.g. .rs files) #6
Comments
That is weird, GDScript shouldn't even be triggered in those files. |
It only happens after the gdscipt lsp is running. Without opening a gdscript file first, the lsp won't be active. |
I think this is more of a Zed bug. It shouldn't check |
could you run |
Zed: v0.141.0 (Zed Dev 4855da53dfa62791d9dd102b9db9cf7ddb08d153) Might be an issue with the linux port? |
Experiencing the same issue. |
@coppolaemilio Do you still have this issue on tres files with the latest release of Zed? On this end, I cannot reproduce it. I can reproduce the issue of the language server running on other programming language files, though. It happens with any programming language it seems. I'm not sure why yet, but I'll try to see if I can find out. If anyone has an idea of what could be the cause, I'm all ears. I'll look into language injections and language server settings, see if something stops the behavior. |
Nope, can't reproduce it anymore. It seems fixed on my end 👍 |
@coppolaemilio Yes! And the idea is to develop it a bit and then if more people start to use Zed offer to transfer it to the foundation like the emacs plugin before. |
Yeah, I threw together the extension just so I could keep working in Zed. But then people started using it and I was unable to keep up. Glad @NathanLovato reached out! |
I am still having this issue (including .tres files). Linux, Zed 0.148.0 |
Hello, I have this issue as well, here's the language server reporting a bunch of issues on my tasks.json file: This happens when:
Zed: v0.164.2 (Zed) |
I took a look at the logs, and it seems that when saving a file, Zed sends I was using Godot 4.2.2, but just checked 4.4 as well in case anything had changed, but that doesn't seem to be the case. So, the problem doesn't seem to be the extension... Zed is sending requests it shouldn't, and Godot is returning responses it shouldn't. Should probably open an issue upstream, but I'm not even sure whether it is Zed or Godot that's most at fault, here. |
I submitted a pull request fixing this into Godot Engine. Thanks @KettLovahr for the detailed response! It seems like Zed used to not send the notification for all file types, but it was reverted in zed-industries/zed/pull/19183, so I submitted the fix into the engine. |
When GDscript is running, the LSP is also active on other filetypes
Is there a config I should add to limit it to only run on GDScript files?
Steps to reproduce:
The text was updated successfully, but these errors were encountered: