Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: validate field paths passed to 'Query.{select,where,order_by}` #6736

Closed
tseaver opened this issue Nov 30, 2018 · 0 comments
Closed

Firestore: validate field paths passed to 'Query.{select,where,order_by}` #6736

tseaver opened this issue Nov 30, 2018 · 0 comments
Assignees
@tseaver
Labels
api: firestore Issues related to the Firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2018

The following conformance tests assert that passing field paths with invalid path elements to Query.select / Query.where / Query.order_by should raise an exception:

  • query-invalid-path-select.textproto
  • query-invalid-path-where.textproto
  • query-invalid-path-order.textproto
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. api: firestore Issues related to the Firestore API. labels Nov 30, 2018
@tseaver tseaver self-assigned this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the Firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tseaver