Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow 'Collection.where("__name__", "in", ["hello", "world"])' #501

Merged

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 7, 2021

Based on branch for PR #499 -- I will rebase after that PR merges.

Fixes #421.

Supersedes #496.

@tseaver tseaver requested review from tswast and kolea2 December 7, 2021 20:40
@tseaver tseaver requested a review from a team as a code owner December 7, 2021 20:40
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 7, 2021
@tseaver tseaver force-pushed the 421-collection-where-__name__-in-w-string-values-rebased branch from 51d820a to a66c097 Compare December 22, 2021 21:22
@tseaver tseaver merged commit 7d71244 into main Dec 23, 2021
@tseaver tseaver deleted the 421-collection-where-__name__-in-w-string-values-rebased branch December 23, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert strings passed for an in query on a DocumentID to DocumentRefs for ease of use
3 participants