Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typing improvement for AsyncCollectionReference and AsyncQuery #781

Closed
sergiterupri opened this issue Oct 16, 2023 · 0 comments · Fixed by #782
Closed

Small typing improvement for AsyncCollectionReference and AsyncQuery #781

sergiterupri opened this issue Oct 16, 2023 · 0 comments · Fixed by #782
Labels
api: firestore Issues related to the googleapis/python-firestore API.

Comments

@sergiterupri
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Typing isn't working well when using AsyncCollectionReference and AsyncQuery. As an example, where method which is inherited on both cases, will "return" a BaseQuery.

Having an AsyncQuery:
Captura de pantalla 2023-10-16 a las 16 56 45

After using where the editor thinks it is a BaseQuery:
Captura de pantalla 2023-10-16 a las 16 57 21

And because of this the editor says I can't do "async stuff":
Captura de pantalla 2023-10-16 a las 16 58 07

Describe the solution you'd like
Correct typing for AsyncCollectionReference and AsyncQuery methods.

Additional context
I'm also providing a small PR with required changes.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant