Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules for directive's arguments not executed if no args declared on directive #63

Closed
Dodobibi opened this issue Sep 21, 2019 · 1 comment

Comments

@Dodobibi
Copy link

If a directive with no argument declared and an arbitrary argument is passed, the rule check is not applied.

This is because know_args is an empty list which return false in if directive_node.arguments and known_args: at Line 63 on /src/graphql/validation/rules/known_argument_names.py

@Cito Cito closed this as completed in ae7ae54 Sep 25, 2019
@Cito
Copy link
Member

Cito commented Sep 25, 2019

👍 Thank you @Dodobibi for reporting this and pinpointing the problematic code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants