From 8ee168b0b26f3e2f49f3b6370b16273fb6e0e9ad Mon Sep 17 00:00:00 2001
From: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
Date: Tue, 14 Jan 2020 17:37:44 +0800
Subject: [PATCH] OverlappingFieldsCanBeMerged: remove excessive caching

This caching is unneeded since fragment names are always collected into
map and does contains duplicates, see:
https://github.com/graphql/graphql-js/blob/6c377ac482e61b8179bb7dd0e44fa0ede8e1a91c/src/validation/rules/OverlappingFieldsCanBeMerged.js#L711
---
 .../rules/OverlappingFieldsCanBeMerged.js          | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/src/validation/rules/OverlappingFieldsCanBeMerged.js b/src/validation/rules/OverlappingFieldsCanBeMerged.js
index caccc45301..5406161763 100644
--- a/src/validation/rules/OverlappingFieldsCanBeMerged.js
+++ b/src/validation/rules/OverlappingFieldsCanBeMerged.js
@@ -191,13 +191,11 @@ function findConflictsWithinSelectionSet(
   if (fragmentNames.length !== 0) {
     // (B) Then collect conflicts between these fields and those represented by
     // each spread fragment name found.
-    const comparedFragments = Object.create(null);
     for (let i = 0; i < fragmentNames.length; i++) {
       collectConflictsBetweenFieldsAndFragment(
         context,
         conflicts,
         cachedFieldsAndFragmentNames,
-        comparedFragments,
         comparedFragmentPairs,
         false,
         fieldMap,
@@ -229,18 +227,11 @@ function collectConflictsBetweenFieldsAndFragment(
   context: ValidationContext,
   conflicts: Array<Conflict>,
   cachedFieldsAndFragmentNames,
-  comparedFragments: ObjMap<boolean>,
   comparedFragmentPairs: PairSet,
   areMutuallyExclusive: boolean,
   fieldMap: NodeAndDefCollection,
   fragmentName: string,
 ): void {
-  // Memoize so a fragment is not compared for conflicts more than once.
-  if (comparedFragments[fragmentName]) {
-    return;
-  }
-  comparedFragments[fragmentName] = true;
-
   const fragment = context.getFragment(fragmentName);
   if (!fragment) {
     return;
@@ -276,7 +267,6 @@ function collectConflictsBetweenFieldsAndFragment(
       context,
       conflicts,
       cachedFieldsAndFragmentNames,
-      comparedFragments,
       comparedFragmentPairs,
       areMutuallyExclusive,
       fieldMap,
@@ -413,13 +403,11 @@ function findConflictsBetweenSubSelectionSets(
   // (I) Then collect conflicts between the first collection of fields and
   // those referenced by each fragment name associated with the second.
   if (fragmentNames2.length !== 0) {
-    const comparedFragments = Object.create(null);
     for (let j = 0; j < fragmentNames2.length; j++) {
       collectConflictsBetweenFieldsAndFragment(
         context,
         conflicts,
         cachedFieldsAndFragmentNames,
-        comparedFragments,
         comparedFragmentPairs,
         areMutuallyExclusive,
         fieldMap1,
@@ -431,13 +419,11 @@ function findConflictsBetweenSubSelectionSets(
   // (I) Then collect conflicts between the second collection of fields and
   // those referenced by each fragment name associated with the first.
   if (fragmentNames1.length !== 0) {
-    const comparedFragments = Object.create(null);
     for (let i = 0; i < fragmentNames1.length; i++) {
       collectConflictsBetweenFieldsAndFragment(
         context,
         conflicts,
         cachedFieldsAndFragmentNames,
-        comparedFragments,
         comparedFragmentPairs,
         areMutuallyExclusive,
         fieldMap2,