-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Able to use upgradeWebSocket
in handler
#3005
Comments
but why a right minded person will create custom response on this kind of thing |
Hi @Lucifer359-IV, for example, you can do that app.get('/ws', c => {
if (!validToken(c.req.query('token'))) {
return c.text('Unauthorized', 400)
}
return upgradeWebSocket(c, {
onOpen () {
console.log('opened!')
}
})
}) Also you can change the response with or without the upgrade header. |
@nakasyou can't you do that token validation with a middleware? Also have you checked the streaming helper section in the docs? |
Yes, but it expand the options. app.get('/:id', upgradeWebSocket((c) => {
c.req.param('id') // not typed
})) To implement this, the problem will be resolved.
Yes. I used "like a stream" in the sense of generating a response, not as a middleware, but that expression may not be appropriate. I will change the title. Thanks. |
upgradeWebSocket
like a streamupgradeWebSocket
in handler
What is the feature you are proposing?
I think accepting using
upgradeWebSocket
like a stream is good.For example:
Because user can write more flexible code such as creating custom response in WebSocket route.
The text was updated successfully, but these errors were encountered: