Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect color support in parity_scale_decoder #4487

Closed
dima74 opened this issue Apr 19, 2024 · 0 comments · Fixed by #4680
Closed

Detect color support in parity_scale_decoder #4487

dima74 opened this issue Apr 19, 2024 · 0 comments · Fixed by #4680
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@dima74
Copy link
Contributor

dima74 commented Apr 19, 2024 •
edited
Loading

Instead of feature-gating it, I would suggest following the same pattern that iroha (crate in /cli/) itself follows:

  • It detects colors support automatically via supports_color crate
  • User can override it by --terminal-colors=false/--terminal-colors=true flag

Originally posted by @0x009922 in #4486 (comment)
@dima74 dima74 added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 19, 2024
@dima74 dima74 mentioned this issue Apr 19, 2024
Merged
5 tasks
@nxsaken nxsaken added the good first issue Good for newcomers label May 14, 2024
@aplio aplio mentioned this issue Jun 3, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add detect support for parity_scale_decoder aplio/iroha
2 participants
@dima74 @nxsaken