You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consider transfer instruction, e.g. Transfer<Account, DomainId, Account>. It checks that source (provided by ISI) equals domain owner (as stored in blockchain):
"Can't transfer domain {domain} since {source} doesn't own it",
)));
}
Consider removing source from ISI and using domain owner directly. Also applicable for CLI (e.g. even if we will keep source in ISI, we can remove source in CLI)
To update the ownership of an object, the object id and the new owner id should be sufficient arguments. So struct Transfer<S, O, D> enforces unnecessary invariant checks for ownership changes
Yeah, every Transfer<S, O, D> can change into Transfer<O, D>, including numeric asset transfers, which can be considered ownership changes for partial balances (O = Asset)
Consider transfer instruction, e.g.
Transfer<Account, DomainId, Account>
. It checks thatsource
(provided by ISI) equals domain owner (as stored in blockchain):iroha/crates/iroha_core/src/smartcontracts/isi/domain.rs
Lines 362 to 366 in e0ff842
Consider removing
source
from ISI and using domain owner directly. Also applicable for CLI (e.g. even if we will keepsource
in ISI, we can removesource
in CLI)Originally posted by @s8sato in #5308 (comment)
The text was updated successfully, but these errors were encountered: