Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Fix for deserialisation of BroadcastTx which was missing a type byte. #516

Merged

Conversation

benjaminbollen
Copy link
Contributor

closes #453;
closes #511: it is necessary to explicitly use go-wire DecodeBytesPtr

  • This should restore the param field to take a type byte for the Transaction type on a call to erisdb.broadcastTx on rpc/v0 as on v0.11; which lapsed in v0.12.
  • Added minimal test to assert correct type recovery.
  • move the test code that exist for rpc/v0 into /eris-db/rpc/v0; it was from lingering in /test/... from olden days.

@zramsay zramsay merged commit 2915d10 into hyperledger-archives:release-0.16 Feb 27, 2017
@benjaminbollen benjaminbollen deleted the issue453-fix branch February 27, 2017 19:46
silasdavis pushed a commit to silasdavis/burrow that referenced this pull request Mar 9, 2019
…453-fix

Fix for deserialisation of BroadcastTx which was missing a type byte.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants