This repository has been archived by the owner on May 13, 2022. It is now read-only.
Upgrade to Tendermint 0.9.2 #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2017 15:13
Use genesis and config makers in test Introduce assertion on global Burrow version and get Application to assert compatible consensus by type
This was referenced May 2, 2017
benjaminbollen
approved these changes
May 2, 2017
| @@ -119,3 +119,8 @@ func (core *Core) NewGatewayTendermint(config *server.ServerConfig) ( | |||
| return rpc_tendermint.NewTendermintWebsocketServer(config, | |||
| core.tendermintPipe, core.evsw) | |||
| } | |||
|
|
|||
| // Stop the core allowing for a graceful shutdown of component in order. | |||
| func (core *Core) Stop() bool { | |||
| // set and voting power distribution see our BlockchainAware interface | ||
| func (app *BurrowMint) EndBlock(height uint64) (respEndblock abci.ResponseEndBlock) { | ||
| // TODO: [Silas] Bondage | ||
| // TODO: [Silas] this might be a better place for us to dispatch new block |
There was a problem hiding this comment.
Actually only issue with that is is that I think they are sending ABCI EndBlock before they save Tendermint state. Not an issue for something things, but may be if you were expecting post-block consensus state to be ready.
|
closes #583 |
This was referenced May 24, 2017
Merged
silasdavis
pushed a commit
to silasdavis/burrow
that referenced
this pull request
Mar 9, 2019
…only Upgrade to Tendermint 0.9.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: