[FAB-5136] Viper shouldn't be exposed in interface

Change-Id: I52bf367ed711daa4e5fb8ede47413bbcf5e83ae3 Signed-off-by: Troy Ronda <[email protected]>
hyperledger · Jun 30, 2017 · cb15534 · cb15534
1 parent f7b2f4f
commit cb15534
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/api/config.go b/api/config.go
@@ -10,7 +10,6 @@ import (
 	"crypto/x509"
 
 	bccspFactory "github.com/hyperledger/fabric/bccsp/factory"
-	"github.com/spf13/viper"
 )
 
 // Config fabric-sdk-go configuration interface
@@ -20,7 +19,6 @@ type Config interface {
 	CAClientKeyFile(org string) (string, error)
 	CAClientCertFile(org string) (string, error)
 	MspID(org string) (string, error)
-	FabricClientViper() *viper.Viper
 	OrderersConfig() ([]OrdererConfig, error)
 	RandomOrdererConfig() (*OrdererConfig, error)
 	OrdererConfig(name string) (*OrdererConfig, error)

diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go
@@ -120,7 +120,6 @@ func TestCAConfigFailsByNetworkConfig(t *testing.T) {
 
 	//Tamper 'client.network' value and use a new config to avoid conflicting with other tests
 	sampleConfig, err := InitConfig("../../test/fixtures/config/config_test.yaml")
-	myViper := sampleConfig.FabricClientViper()
 	clientNetworks := myViper.Get("client.network")
 	myViper.Set("client.network", "INVALID")
 	//...
@@ -314,16 +313,13 @@ func TestInitConfig(t *testing.T) {
 	}
 
 	//Test if Viper is initialized after calling init config
-	myViper := configImpl.FabricClientViper()
-
 	if myViper.GetString("client.security.hashAlgorithm") != configImpl.SecurityAlgorithm() {
 		t.Fatal("Config initialized with incorrect viper configuration")
 	}
 
 }
 
 func TestInitConfigPanic(t *testing.T) {
-	myViper := configImpl.FabricClientViper()
 	existingLogLevel := myViper.Get("client.logging.level")
 	myViper.Set("client.logging.level", "INVALID")