Skip to content

Commit

Permalink
Revert 721- Prevent Jenkins build from cleaning baseimage
Browse files Browse the repository at this point in the history
Revert commit 84d1234 which was
inadvertently merged despite there being outstanding concerns.

Change-Id: Idbe47347e1008da28cd7730947c7225e74a12c5b
Signed-off-by: Christopher Ferris <[email protected]>
  • Loading branch information
christo4ferris committed Sep 1, 2016
1 parent 2552dd0 commit 45e6cf3
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@
# - gotools - installs go tools like golint
# - linter - runs all code checks
# - images[-clean] - ensures all docker images are available[/cleaned]
# - images-scrub - ensures all docker images are cleaned including fabric-baseimage
# - peer-image[-clean] - ensures the peer-image is available[/cleaned] (for behave, etc)
# - membersrvc-image[-clean] - ensures the membersrvc-image is available[/cleaned] (for behave, etc)
# - protos - generate all protobuf artifacts based on .proto files
# - node-sdk - builds the node.js client sdk
# - node-sdk-unit-tests - runs the node.js client sdk unit tests
# - clean - cleans the build area
# - dist-clean - superset of 'clean' that also removes persistent state
# - dist-scrub - superset of 'clean' that also removes fabric-baseimage

PROJECT_NAME = hyperledger/fabric
BASE_VERSION = 0.6.0
Expand Down Expand Up @@ -71,8 +69,7 @@ BASEIMAGE_DEPS = $(shell git ls-files images/base scripts/provision)

JAVASHIM_DEPS = $(shell git ls-files core/chaincode/shim/java)
PROJECT_FILES = $(shell git ls-files)
SUBIMAGES = src ccenv peer membersrvc javaenv
IMAGES = base $(SUBIMAGES)
IMAGES = base src ccenv peer membersrvc javaenv

all: peer membersrvc checks

Expand Down Expand Up @@ -254,19 +251,14 @@ src-image-clean: ccenv-image-clean peer-image-clean membersrvc-image-clean
-docker images -q $(PROJECT_NAME)-$(TARGET) | xargs -r docker rmi -f
-@rm -rf build/image/$(TARGET) ||:

images-clean: $(patsubst %,%-image-clean, $(SUBIMAGES))

images-scrub: $(patsubst %,%-image-clean, $(IMAGES))
images-clean: $(patsubst %,%-image-clean, $(IMAGES))

.PHONY: $(SUBDIRS:=-clean)
$(SUBDIRS:=-clean):
cd $(patsubst %-clean,%,$@) && $(MAKE) clean

.PHONY: clean
clean: images-clean $(filter-out gotools-clean, $(SUBDIRS:=-clean))

.PHONY: scrub
scrub: images-scrub $(filter-out gotools-clean, $(SUBDIRS:=-clean))
-@rm -rf build ||:

.PHONY: dist-clean
Expand Down

0 comments on commit 45e6cf3

Please sign in to comment.