Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFT Block Puller: Remove redundant internal map in deliveryServiceImpl.blockproviders #4261

Closed
Tracked by #4240
tock-ibm opened this issue Jun 4, 2023 · 2 comments
Closed
Tracked by #4240

Comments

@tock-ibm
Copy link
Contributor

tock-ibm commented Jun 4, 2023

The gossip service:

  • It contains a map of channelID -> DeliverService (an interface).
  • The DeliveryService is implemented by a deliveryServiceImpl, which contains blockProviders a map of channelID -> Deliverer.
  • The implementation shows that the external and internal maps are always keyed together, with the same channelID, which means that the internal map has always a single entry...

Remove the redundant internal map.

@tock-ibm tock-ibm changed the title Remove redundant internal map in deliveryServiceImpl.blockproviders BFT Block Puller: Remove redundant internal map in deliveryServiceImpl.blockproviders Jun 4, 2023
@tock-ibm
Copy link
Contributor Author

Done

@tock-ibm
Copy link
Contributor Author

There is a bug:

After the delivery service StopDeliveryForChannel is called, it should be possible to call StartDeliveryForChannel again.
After the delivery service Stop is called, it should not be possible to call <Start/Stop>DeliveryForChannel again.

This was introduced by #4260

@tock-ibm tock-ibm reopened this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant