Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFT Block Puller: expose BlockCensorshipTimeout in config #4401

Closed
Tracked by #4240
tock-ibm opened this issue Aug 27, 2023 · 1 comment
Closed
Tracked by #4240

BFT Block Puller: expose BlockCensorshipTimeout in config #4401

tock-ibm opened this issue Aug 27, 2023 · 1 comment
Assignees

Comments

@tock-ibm
Copy link
Contributor

tock-ibm commented Aug 27, 2023

File core/deliverservice/config.go defines configuration variables that are used in the CFT and BFT delivery clients.
We should add to that a

  • BlockCensorshipTimeout that is used in the BFT deliverer.
  • MinimalReconnectInterval (now is a baked in number 100ms
// DeliverServiceConfig is the struct that defines the deliverservice configuration.
type DeliverServiceConfig struct {
	// PeerTLSEnabled enables/disables Peer TLS.
	PeerTLSEnabled bool
	// BlockGossipEnabled enables block forwarding via gossip
	BlockGossipEnabled bool
	// ReConnectBackoffThreshold sets the delivery service maximal delay between consecutive retries.
	ReConnectBackoffThreshold time.Duration
	// ReconnectTotalTimeThreshold sets the total time the delivery service may spend in reconnection attempts
	// until its retry logic gives up and returns an error.
	ReconnectTotalTimeThreshold time.Duration
	// ConnectionTimeout sets the delivery service <-> ordering service node connection timeout
	ConnectionTimeout time.Duration
	// Keepalive option for deliveryservice
	KeepaliveOptions comm.KeepaliveOptions
	// SecOpts provides the TLS info for connections
	SecOpts comm.SecureOptions

	// OrdererEndpointOverrides is a map of orderer addresses which should be
	// re-mapped to a different orderer endpoint.
	OrdererEndpointOverrides map[string]*orderers.Endpoint
}

Update also the peer yaml files that are loaded from the file system on startup, and set reasonable defaults if these values are not found.

@tock-ibm
Copy link
Contributor Author

See func (d *deliverServiceImpl) createBlockDelivererBFT in PR #4373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants