Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #3087: Collect votes from observing peers after view change. #3097

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

SamHSmith
Copy link
Contributor

Signed-off-by: Sam H. Smith [email protected]

Description of the Change

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@SamHSmith SamHSmith requested a review from s8sato as a code owner January 30, 2023 15:21
@SamHSmith SamHSmith self-assigned this Jan 30, 2023
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 30, 2023
@Erigara Erigara self-assigned this Jan 30, 2023
@SamHSmith SamHSmith force-pushed the observing_peers branch 2 times, most recently from c298c82 to 1d13496 Compare January 30, 2023 15:27
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3097 (d976c7a) into iroha2-dev (a4d5c9f) will increase coverage by 2.76%.
The diff coverage is 71.27%.

@@              Coverage Diff               @@
##           iroha2-dev    #3097      +/-   ##
==============================================
+ Coverage       62.33%   65.09%   +2.76%     
==============================================
  Files             169      171       +2     
  Lines           31218    33506    +2288     
==============================================
+ Hits            19459    21810    +2351     
+ Misses          11759    11696      -63     
Impacted Files Coverage Δ
cli/src/main.rs 1.09% <0.00%> (ø)
cli/src/torii/mod.rs 27.65% <ø> (ø)
cli/src/torii/utils.rs 75.00% <0.00%> (-9.85%) ⬇️
client_cli/src/main.rs 0.24% <0.00%> (-0.01%) ⬇️
config/base/src/lib.rs 91.57% <ø> (+55.21%) ⬆️
config/src/lib.rs 33.33% <ø> (ø)
config/src/logger.rs 70.21% <ø> (ø)
config/src/path.rs 0.00% <0.00%> (ø)
core/src/lib.rs 100.00% <ø> (ø)
core/src/smartcontracts/isi/block.rs 85.71% <ø> (-3.18%) ⬇️
... and 168 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SamHSmith SamHSmith force-pushed the observing_peers branch 2 times, most recently from 0ead6b3 to 5f3f972 Compare January 30, 2023 15:51
@appetrosyan appetrosyan self-assigned this Jan 30, 2023
@mversic mversic self-assigned this Jan 31, 2023
mversic
mversic previously approved these changes Feb 1, 2023
@SamHSmith SamHSmith merged commit 786e3d3 into hyperledger-iroha:iroha2-dev Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants