-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #3087: Collect votes from observing peers after view change. #3097
Merged
SamHSmith
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
SamHSmith:observing_peers
Feb 1, 2023
Merged
[fix] #3087: Collect votes from observing peers after view change. #3097
SamHSmith
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
SamHSmith:observing_peers
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c298c82
to
1d13496
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3097 +/- ##
==============================================
+ Coverage 62.33% 65.09% +2.76%
==============================================
Files 169 171 +2
Lines 31218 33506 +2288
==============================================
+ Hits 19459 21810 +2351
+ Misses 11759 11696 -63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0ead6b3
to
5f3f972
Compare
Erigara
suggested changes
Jan 31, 2023
mversic
requested changes
Jan 31, 2023
5f3f972
to
cd38bce
Compare
Erigara
reviewed
Jan 31, 2023
mversic
reviewed
Jan 31, 2023
cd38bce
to
17dab72
Compare
mversic
previously approved these changes
Feb 1, 2023
…r view change. Signed-off-by: Sam H. Smith <[email protected]>
17dab72
to
d976c7a
Compare
mversic
approved these changes
Feb 1, 2023
Erigara
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sam H. Smith [email protected]
Description of the Change
Issue
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]