Use the crypto provider corresponding to public key type during runtime #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBoldyrev
force-pushed
the
feature/runtimecrypto
branch
from
8066d6d to
62ec017
Compare
lebdron
reviewed
May 13, 2020
| template <typename Container> | ||
| inline auto hexstringToBytestringSize(Container const &c) | ||
| -> decltype(c.size()) { | ||
| return (c.size() + 1) / 2; |
There was a problem hiding this comment.
I wonder if strings with odd size were encountered somewhere
There was a problem hiding this comment.
I would prefere general logic where it is cheap.
lebdron
approved these changes
May 29, 2020
iceseer
approved these changes
May 29, 2020
use the correct crypto provider during runtime, depending on public key type Signed-off-by: Alexander Matson <[email protected]> Signed-off-by: Mikhail Boldyrev <[email protected]>
Signed-off-by: Mikhail Boldyrev <[email protected]>
MBoldyrev
force-pushed
the
feature/runtimecrypto
branch
from
57ff160 to
f3181fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Note: This PR is based on the changes in #263, so that should be reviewed before this one.
This change modifies the
CryptoSignerto run the correct signing implementation, depending on the input public key type.KeysManagerImplalso had to be changed so it can correctly load both ursa-keys and iroha-keys from files, depending only on the imported public key. This also assumes Iroha is compiled with the build flagLIBURSA=ON.Benefits
During runtime, Iroha can correctly load ursa-generated keys or iroha-generated keys from files, and use them to sign and verify blocks.
Possible Drawbacks
None
Usage Examples or Tests [optional]
Alternate Designs [optional]