Fix/mst state #378
Merged
Fix/mst state #378
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceseer
requested review from
lebdron and
MBoldyrev
and removed request for
lebdron
MBoldyrev
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Good overal, though please mind the rules of includes placement. #338 (comment)
test/framework/integration_framework/fake_peer/network/mst_network_notifier.hpp
Outdated
Show resolved
Hide resolved
test/module/irohad/multi_sig_transactions/mst_processor_test.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
ekovalev
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
transit mst state by rvalref
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]