Kapacitor Rule Alert Config for HTTP, TCP, Exec, SMTP, and Alerta (parsed pasted Tick script) #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ui/src/kapacitor/components/RuleMessage.js
… rule alert config.
cryptoquick
changed the title
121watts
suggested changes
Feb 10, 2017
|
|
||
| const alerts = enabledAlerts.map((text) => { | ||
| return {text, ruleID: rule.id}; | ||
| }).concat(defaultAlertEndpoints); |
There was a problem hiding this comment.
There's an issue here with SMTP. SMTP can be both preconfigured and default. So, we run the risk of it showing up twice.
There was a problem hiding this comment.
This should be good now, it's been fixed in the constants.
ui/src/kapacitor/reducers/rules.js
Outdated
| @@ -1,6 +1,26 @@ | |||
| import {defaultRuleConfigs, DEFAULT_RULE_ID} from 'src/kapacitor/constants'; | |||
| import _ from 'lodash'; | |||
|
|
|||
| const alertaRegex = /(services)\('(.+?)'\)|(resource)\('(.+?)'\)|(event)\('(.+?)'\)|(environment)\('(.+?)'\)|(group)\('(.+?)'\)|(origin)\('(.+?)'\)|(token)\('(.+?)'\)/gi; | |||
|
|
|||
| function parseAlerta(string, regex) { | |||
There was a problem hiding this comment.
This should probably be pulled out of the reducer and put into the shared/parsing dir and have it's own spec.
| return (<input | ||
| className="form-control col-xs-6" | ||
| type="text" | ||
| placeholder={DEFAULT_ALERT_PLACEHOLDERS[alert]} |
There was a problem hiding this comment.
This could also probably use a label based one the alert also.
| return strs; | ||
| }, ['alerta()']).join('.'), | ||
| }; | ||
|
|
There was a problem hiding this comment.
These are awesome and should probably be pulled out into the constants folder.
121watts
suggested changes
Feb 10, 2017
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }, | ||
|
|
||
| renderInput(updateAlertNodes, alert, rule) { |
There was a problem hiding this comment.
Would this be better as its own component?
…rately. Refactor parseAlerta out of rules reducer into its own file in shared/prasing. Update appearance of AlertaConfig. Update appearance of RuleMessage input field. Remove smtp and alerta from default alerts.
…to the ALERTS constant.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
121watts
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #625
Connect #713
Connect #782
Connect #793
Connect #801
Connect #834
The problem
TCP and HTTP kapacitor rule alert config support was implemented on the backend, but needed UI to support it. Exec, SMTP, and Alerta support has also been requested.
The Solution
Implement support in UI.
For Alerta we decided to allow users to paste their Tick script in order to properly configure all available options.