Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I can see an edit overlay #950

Closed
nhaugo opened this issue Mar 2, 2017 · 1 comment
Closed

As a user I can see an edit overlay #950

nhaugo opened this issue Mar 2, 2017 · 1 comment
Assignees
@jaredscheib
Milestone
1.2.0-beta6

Comments

@nhaugo
Copy link
Contributor

nhaugo commented Mar 2, 2017 •
edited by 121watts
Loading

• This puts a yellow border around the selected graph 
• This opens an overlay area

graph-editing.pdf
@nhaugo nhaugo added the ready label Mar 2, 2017
@nhaugo nhaugo added this to the 1.2.0-beta6 milestone Mar 7, 2017
@jaredscheib jaredscheib self-assigned this Mar 13, 2017
@jaredscheib jaredscheib mentioned this issue Mar 13, 2017
Merged
4 tasks
@lukevmorris
Copy link
Contributor

lukevmorris commented Mar 18, 2017 •
edited
Loading

We now have the ability to add/remove queries in a cell, and edit a particular query, within Overlay Technologies. Still to do:

  • Communicate with Goller about dashboard/cell schema changes
  • Determine whether Visualization Type is something we can modify in Overlay Technologies
  • Related: Are we modifying a cell's name here too?
  • If we're modifying cell-level properties, refactor some code so that CellEditorOverlay is clearly cell-specific
  • Save/Cancel changes made to the cell while in the overlay

@goller goller mentioned this issue Mar 21, 2017
Merged
5 tasks
@nhaugo nhaugo closed this as completed Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredscheib jaredscheib

Labels
None yet
Projects
None yet
Milestone
1.2.0-beta6
Development

No branches or pull requests
3 participants
@nhaugo @lukevmorris @jaredscheib