Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name provided to TICKscript replaced by Identifier #3166

Closed
karel-rehor opened this issue Apr 10, 2018 · 4 comments
Closed

Name provided to TICKscript replaced by Identifier #3166

karel-rehor opened this issue Apr 10, 2018 · 4 comments
Assignees
Milestone

Comments

@karel-rehor
Copy link

karel-rehor commented Apr 10, 2018

I'm pretty sure this must be reported somewhere, but I have been unable to find it in current open issues.

When saving a new TICKscript with a name, the TICKscript appears in the Manage Tasks page's TICKscripts table listed by its identifier in the "name" column and not by the "name" the user assigned to it.

Further when opening the script again, the Identifier appears in place of the name.

tickscriptname01
tickscriptname02
tickscriptname03
tickscriptname04
tickscriptname05

I've just written an automated test for creating a TICKscript and the last assertion is that the script should be found in the Manage Tasks page by "name".

$ chronograf --version
2018/04/11 10:26:28 Chronograf 1.2.0~n201804100832 (git: 7faec8b6be473720206f974dcb95df39aefe032b)
@russorat
Copy link
Contributor

russorat commented Apr 11, 2018

good find. this is probably a side effect of #3019

@121watts
Copy link
Contributor

@russorat we are POSTing the arbitrary id to the backend. But, it seems like the backend is overwriting the user assigned id if the Tickscript cannot be parsed into an 'AlertRule'.

@odarriba
Copy link
Contributor

odarriba commented May 10, 2018

I'm seeing the same issue in 1.4.4.2 :( any news about this?

root@metrics:~# chronograf -v
2018/05/10 15:09:06 Chronograf 1.4.4.2 (git: cc398c105f97f2b13aa5f38d1ff1d2c5cae2d5af)

@russorat
Copy link
Contributor

russorat commented May 10, 2018

@odarriba i'm reopening this so we can find a better solution.

  • give the user the ability to set the id of a kapacitor task from the frontend. once the task id is set once, they don't need to be able to change it, but a user should be able to provide a task id on script creation to be used when referencing the task in kapacitor so that they don't see guids. this does not apply to alert rules which are managed by chronograf.

image

@russorat russorat reopened this May 10, 2018
@bthesorceror bthesorceror self-assigned this May 10, 2018
@russorat russorat added this to the 1.5.0 milestone May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants