-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g:fsharp#languageserver_command is not defined after installing Ionide-vim #8
Comments
Looks like the issue could be related to my switch to Vim8's built-in package manager |
I haven't really tested |
As a workaround for now, you can use Plug or dein.vim and it should work as expected. |
Did you use |
Yes, I used install.sh. I’m not interested in using plug or dein.vim, so I’ll pass for now. Thanks. |
If you've installed to |
If not, let me know and I'll set up a new Ubuntu environment and try to figure out why it isn't working. |
@cannorin I have the same issue actually, installing with Plug :D running vim on mac osx! |
@giulioungaretti It could be because you added let g:LanguageClient_serverCommands = {
\ 'fsharp': g:fsharp#languageserver_command
\ } before you installed the plugin by executing |
:PlugInstall ✔️ Open vim in ~ get:
Open a .fs file:
Run said command:
Which makes me think it could be related to some PATH issues ? |
Ah, my bad. That's because I placed the existence-checking code before defining commands: https://github.com/ionide/Ionide-vim/blob/master/ftplugin/fsharp.vim#L11 As a workaround, could you try doing |
It's still not working for me. :( I'll continue to try again every so often. |
@panesofglass I'll reproduce your environment and try to find out why it isn't working. Could you provide me the location of Ionide-vim and your .vimrc? |
@giulioungaretti 5f4f194 addressed the problem |
@cannorin thank you! On Windows, I'm using |
|
@giulioungaretti @panesofglass I just created The languageserver configuration is now done automatically and let g:LanguageClient_serverCommands = {
\ 'fsharp': g:fsharp#languageserver_command
\ } in vimrc/init.vim is not needed anymore. |
@cannorin it works wonderfully with that branch! |
@giulioungaretti Great to hear that! |
I've updated everything, but I still see the error on both wsl2 and windows. Maybe I missed something? |
@panesofglass Make sure you removed the |
Ah, thanks! I missed that bit. It works great now! By the way, if I wanted to add additional language server commands, would I just not add anything about fsharp? |
Thanks! I'll merge the fix now. The current implementation of Ionide-vim only adds the F# language server command when editing F# files, so you can just add language server of another languages. |
@panesofglass @giulioungaretti Don't forget to switch back to the master branch (I'll delete the issue branch in few days). Thanks a lot for reporting a bug 😂 |
Describe the bug
g:fsharp#languageserver_command
is not defined after installing Ionide-vim.To Reproduce
Steps to reproduce the behaviour:
nvim .
Expected behaviour
Correctly load a pre-configured variable named
g:fsharp#languageserver_command
to issue commands to FSAC.Screenshots
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: