Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidePanelWidth buggy #3721

Closed
ilan-schemoul opened this issue Jul 6, 2024 · 3 comments · Fixed by #4287
Closed

sidePanelWidth buggy #3721

ilan-schemoul opened this issue Jul 6, 2024 · 3 comments · Fixed by #4287
Labels
bug Something isn't working

Comments

@ilan-schemoul
Copy link

The doc says sidePanelWidth goes from 0 to 1.0 and it's a ratio. But either there's a bug or I don't have a clue how it works (then the doc can be improved)
Describe the bug
sidePanelWidth: 0.3
Capture d'écran 2024-07-06 221446
sidePanelWidth: 0.4
Capture d'écran 2024-07-06 221458
sidePanelWidth: 0.6
Capture d'écran 2024-07-06 221512
](url)

Version info:
commit=6fcb7eb8bb616c170506312870b3bf15f3dbe37c, build date=2024-05-19T10:15:28Z, build source=binaryRelease, version=0.42.0, os=linux, arch=amd64, git version=2.34.1

Additional context
Add any other context about the problem here.

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.
@ilan-schemoul ilan-schemoul added the bug Something isn't working label Jul 6, 2024
@joshgoebel
Copy link

Same behavior here:

commit=ef718f3386df3db4c062103266c007a3fca46c61, build date=2025-01-03T09:19:14Z, build source=unknown, version=ef718f33, os=darwin, arch=arm64, git version=2.47.1

@ilan-schemoul
Copy link
Author

reproduced on 0.45.2

@ChrisMcD1
Copy link
Contributor

Taking a look into this! Seems to just be some silly math computing the ratios of the two sections. I don't think anybody was designed to have the side window taking up the majority of their screen. If so, the full screen view was the intended view.... But should be fixable, so you can enjoy 80% of the screen being the branch names 😉

@ChrisMcD1 ChrisMcD1 mentioned this issue Feb 19, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change side panel width calculation to work for larger numbers ChrisMcD1/lazygit
3 participants
@joshgoebel @ilan-schemoul @ChrisMcD1