Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Logging Levels #15634

Open
11 tasks
laky241 opened this issue Feb 19, 2025 · 2 comments · May be fixed by #15653
Open
11 tasks

Inconsistent Logging Levels #15634

laky241 opened this issue Feb 19, 2025 · 2 comments · May be fixed by #15653

Comments

@laky241
Copy link

laky241 commented Feb 19, 2025

What happened?

logging levels (console.log, console.warn, console.error) are used inconsistently.

Some places use console.log for error messages instead of console.error, while other parts of the code mix direct console calls and logger

This inconsistency makes debugging difficult and can lead to missed error logs.

we should Use console.error for actual error messages instead of console.log.

replace direct console calls with the logger module where applicable.

Example
Incorrect Logging (in react/features/base/logging/functions.js)

console.log('An error occurred:', error);

Platform

  • Chrome (or Chromium based)
  • Firefox
  • Safari
  • Other desktop browser
  • Android browser
  • iOS browser
  • Electron app
  • Android mobile app
  • iOS mobile app
  • Custom app using a mobile SDK

Browser / app / sdk version

133.0.6943.126 (Official Build)

Relevant log output

Reproducibility

  • The problem is reproducible on meet.jit.si

More details?

No response

@laky241
Copy link
Author

laky241 commented Feb 19, 2025

If it's unintended, I’d be happy to work on a fix.

@saghul
Copy link
Member

saghul commented Feb 20, 2025

This is a very nuanced one :-)

I generally agree with the idea, but it's not a clear cut. Something may fail, but iit it's not a fatal error we may log it as a warning.

If you take a go at it we can discuss in a PR review.

@laky241 laky241 linked a pull request Feb 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants