We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging levels (console.log, console.warn, console.error) are used inconsistently.
Some places use console.log for error messages instead of console.error, while other parts of the code mix direct console calls and logger
This inconsistency makes debugging difficult and can lead to missed error logs.
we should Use console.error for actual error messages instead of console.log.
replace direct console calls with the logger module where applicable.
Example Incorrect Logging (in react/features/base/logging/functions.js)
console.log('An error occurred:', error);
133.0.6943.126 (Official Build)
No response
The text was updated successfully, but these errors were encountered:
If it's unintended, I’d be happy to work on a fix.
Sorry, something went wrong.
This is a very nuanced one :-)
I generally agree with the idea, but it's not a clear cut. Something may fail, but iit it's not a fatal error we may log it as a warning.
If you take a go at it we can discuss in a PR review.
Successfully merging a pull request may close this issue.
What happened?
logging levels (console.log, console.warn, console.error) are used inconsistently.
Some places use console.log for error messages instead of console.error, while other parts of the code mix direct console calls and logger
This inconsistency makes debugging difficult and can lead to missed error logs.
we should Use console.error for actual error messages instead of console.log.
replace direct console calls with the logger module where applicable.
Example
Incorrect Logging (in react/features/base/logging/functions.js)
console.log('An error occurred:', error);
Platform
Browser / app / sdk version
133.0.6943.126 (Official Build)
Relevant log output
Reproducibility
More details?
No response
The text was updated successfully, but these errors were encountered: