HBW-97 Add 'required' option for string inputs #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimAle
force-pushed
the
HBW-97
branch
2 times, most recently
from
f97a5c7 to
5f6a8f9
Compare
sugarfree1
suggested changes
Jan 17, 2019
| }, | ||
|
|
||
| isValid () { | ||
| return this.props.params.nullable ? true : this.isFilled(); |
There was a problem hiding this comment.
return this.props.params.nullable || this.isFilled();
| }, | ||
|
|
||
| isValid () { | ||
| return this.props.params.nullable ? true : this.isFilled(); |
There was a problem hiding this comment.
this.props.params.nullable || this.isFilled();
| @@ -185,11 +192,26 @@ modulejs.define('HBWFormString', ['React', 'jQuery'], (React, jQuery) => { | |||
| }, | |||
|
|
|||
| isValid () { | |||
| return (this.state.value || '').search(new RegExp(this.props.params.regex)) >= 0; | |||
| const requiredOK = this.props.params.required ? this.isFilled() : true; | |||
There was a problem hiding this comment.
!this.props.params.required || this.isFilled()
| @@ -185,11 +192,26 @@ modulejs.define('HBWFormString', ['React', 'jQuery'], (React, jQuery) => { | |||
| }, | |||
|
|
|||
| isValid () { | |||
| return (this.state.value || '').search(new RegExp(this.props.params.regex)) >= 0; | |||
| const requiredOK = this.props.params.required ? this.isFilled() : true; | |||
| const regexOK = this.props.params.regex ? this.regexMatched() : true; | |||
* Use `nullable: false` in select/select_table for the same purposes
sugarfree1
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullable: falsein select/select_table for the same purposes