Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Failed HTTP outgoing requests are not tracked on .NET Core #780

Closed
lmolkova opened this issue Jan 9, 2018 · 1 comment
Closed

Failed HTTP outgoing requests are not tracked on .NET Core #780

lmolkova opened this issue Jan 9, 2018 · 1 comment
Labels
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented Jan 9, 2018

Commit 38865b6

Prevents dependency to be collected when response is null. This corresponds to the valid case when an exception was thrown during request processing (because of network, dns, timeout). This case is treated specially in the code.

It is logged in internal telemetry as

AI (Internal): HttpCoreDiagnosticSourceListener OnNext failed to call event handler. Error details 'Event System.Net.Http.HttpRequestOut.Stop: cannot cast response to expected type HttpResponseMessage' 

Tests for failed/canceled requests should be verified or implemented if missing.

@lmolkova lmolkova added the bug label Jan 9, 2018
@Dmitry-Matveev Dmitry-Matveev added this to the 2.6-Beta1 milestone Feb 20, 2018
@Dmitry-Matveev
Copy link
Member

This issue currently seems to be at Top-11 of AI (Internal) telemetry across 2.4 and 2.5 Base SDKs, adding to the scope of 2.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants