Fix letsencrypt missing parameters #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3638 Update `core/terraform/outputs.sh` to handle empty `tre_output.json` file * Add a check to see if `tre_output.json` is empty * If `tre_output.json` is empty, run `terraform init` to recreate it --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3638?shareId=XXXX-XXXX-XXXX-XXXX).
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit c3a12cd. ♻️ This comment has been updated with latest results. |
|
/test-force-approve Lets encrypt not tested in CI. |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 8a3889f) (in response to this comment from @marrobi) |
jonnyry
approved these changes
Feb 5, 2025
tamirkamara
approved these changes
Feb 5, 2025
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit c3a12cd) (in response to this comment from @tamirkamara) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3638
Update
core/terraform/outputs.shto handle emptytre_output.jsonfiletre_output.jsonis emptytre_output.jsonis empty, runterraform initto recreate itFor more details, open the Copilot Workspace session.