Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test welcome content on custom tree views #93747

Closed
1 task done
alexr00 opened this issue Mar 30, 2020 · 1 comment
Closed
1 task done

Test welcome content on custom tree views #93747

alexr00 opened this issue Mar 30, 2020 · 1 comment

Comments

@alexr00
Copy link
Member

alexr00 commented Mar 30, 2020

Refs: #92143 #91269

Complexity: 4


There's a new API which lets extensions contribute content to welcome views. We have finalized the API this milestone.

One reference implementation is the git extension which contributes certain welcome view contents to the scm viewlet, whenever no git is installed or no repository is open, etc. You can use the git extension and the https://github.com/microsoft/vscode-extension-samples/tree/master/tree-view-sample as starting points.

Make sure your extension does not enableProposedAPI.
Test that:

You can contribute content to welcome views for a custom view (for example one of the custom views in the tree view sample).
Content supports Markdown style links (including title, href and tooltip) and new lines with \n
Links isolated in single lines are buttons by convention
Said content can be visible based upon a when clause
The content is only visible when the tree has no data and the tree view doesn't provide a message.

@alexr00 alexr00 added this to the March 2020 milestone Mar 30, 2020
@weinand weinand removed their assignment Apr 1, 2020
@weinand
Copy link
Contributor

weinand commented Apr 1, 2020

@alexr00 Everything works fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants