Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out forbidden characters for file names generated from title (windows) #26689

Open
2 tasks done
mercuree opened this issue Feb 23, 2025 · 1 comment
Open
2 tasks done

Comments

@mercuree
Copy link
Contributor

mercuree commented Feb 23, 2025

Your idea

The default file name is the same as the title if you specify the title in the New score dialog:

Image

However, if the title contains characters that are prohibited (for Windows, see Naming Conventions), such as double quotes, this will not allow you to save the file - the error "The file name is not valid" will appear:

Image

It is important to note that from the message it is not clear which symbols are invalid.
Musescore should also check the file name at the stage of clicking on the "Save" button and display an informative message if the file name contains prohibited characters.

Problem to be solved

Not to confuse the user with uninformative messages

Prior art

No response

Additional context

This issue is based on a report from https://musescore.org/en/node/375422

Checklist

  • This request follows the guidelines for reporting issues
  • I have verified that this feature request has not been logged before, by searching the issue tracker for similar requests
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 23, 2025

IIRC Mu3 did that.
BTW: On renaming a file in Windows Explorer this is shown:
Image
Under macOS and Linux these are all allowed (except for /), as far as I can tell, but using them there isn't a good idea either

Filtering those out may not be needed, but a meaninfull error message (like the above from Windows) definitely is.
And maybe a warning about them on macOS and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants