Plans folder gives false sense of editability

[davetsay]

Overview

Deployment specific. VIPER Plans folder does not prevent editing actions such as creating and/or renaming objects. Will get persistence errors.

Expected Behavior

Folder shouldn't be selectable for create destination. Name should not be editable.

Steps to Reproduce

create

1. Create any object from the Create Menu
2. Select VIPER Plans Folder to save into
3. Save

rename

1. Select VIPER Plans Folder
2. Rename a plan via the browse bar

[jvigliotta]

Testing

For non-persistable folders (ex. dictionaries, couch search folders):

• try to edit properties
• try to change the name in the browse bar (object view)
• try to make a new folder
• try to set primary location
• try to import from json
• make sure none of the above are possible

[charlesh88]

Verified fixed Testathon 12-13-21.

[nikhilmandlik]

Can context click on Viper Plans and edit properties (and also for its child Plans objects)

[unlikelyzero]

Re-opening based on

Can context click on Viper Plans and edit properties (and also for its child Plans objects)

[jvigliotta]

This was fixed, but then overwritten in new form stuff, new PR #4587 should reintroduce those checks.

[unlikelyzero]

Retest

[nikhilmandlik]

Unable to create plane view. 😭

[akhenry]

I have also observed this with other non-editable folder types, so the fix should not be limited to plan folders.

[unlikelyzero]

Still an issue

[akhenry]

Suspect that this is an instance of this broader problem - #4323

[khalidadil]

Edit: Plans are still editable, but it seems like they shouldn't be. The Plans folder itself is not editable.

[nikhilmandlik]

Verified Fixed.