-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement Clock object and indicator in Vue.js #4042
Comments
@khalidadil , can you do this one before the dialog one please? thanks. |
The legacy clock allowed the user to select a time zone and a clock format. Re-implementing that functionality is blocked by the ongoing form refactoring work, so for now it's ok for new clocks to be created with a hard coded time zone (UTC) and format. The new clock object should still support user-specified time zones and display formats though, in order to retain support for legacy clock objects, and in preparation for our new forms and create action. |
Testing instructions
It would be useful to make sure the timer still works properly as well since code around it was removed for this change. |
Testathon 9-20-21: Clock object not available to create and not displayed in the Status area. Unverified. |
Since this was taken out of the angular bundles and installed as a plugin it needs to be manually installed in deployments. @khalidadil . We can retest after we install in VIPER repo. |
testable after change made on viper repo |
Looks good to me! I tested the timer as well and didn't see any issues. Verified Fixed - Testathon 9/28 |
The existing Clock object and the associated indicator are currently implemented as a legacy bundle and written in Angular.js . They should be re-implemented as a plugin under
/src/plugins
using our current API, with the UI migrated to Vue.The Timer should not be re-implemented just yet, just the clock object and clock indicator. Re-implementing the timer should be addressed separately as its functionality is a little more nuanced and we need to decide on the correct design approach.
A followup issue has also been created to enhance the clock object and indicator to support remote clocks, but that can be addressed in a future PR.
Any legacy code associated with the legacy Clock object and indicator should be removed from the code-base.
The text was updated successfully, but these errors were encountered: