Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user name attribution to Notebook entries #4599

Closed
akhenry opened this issue Dec 16, 2021 · 4 comments · Fixed by #4764
Closed

Add user name attribution to Notebook entries #4599

akhenry opened this issue Dec 16, 2021 · 4 comments · Fixed by #4764
Assignees
Labels

Comments

@akhenry
Copy link
Contributor

akhenry commented Dec 16, 2021

Is your feature request related to a problem? Please describe.
Notebook entries should display the name of the user who created them.

Describe the solution you'd like
The new User API allows for components to retrieve basic information about the logged in user. This API should be used to fetch the logged in user's name, and persist it along with notebook entries. The name should how shown in the notebook entry somewhere.

@unlikelyzero
Copy link
Contributor

unlikelyzero commented Dec 17, 2021

I'd like to be involved in writing some e2e tests on the first pass

@jvigliotta
Copy link
Contributor

Testing

  • if you are using openmct WITHOUT a user provider, make sure normal notebook snapshots and entries work as expected
    With a user provider
  • take a snapshot (make sure it works)
  • save to default notebook (navigate to default notebook, verify username is on entry)
  • in a notebook, add an entry, make sure your username is on the entry

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 03/14/2022

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants