Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent time setting persists across domain objects #4722

Closed
3 of 5 tasks
shefalijoshi opened this issue Jan 14, 2022 · 5 comments · Fixed by #4723 or #4783
Closed
3 of 5 tasks

Independent time setting persists across domain objects #4722

shefalijoshi opened this issue Jan 14, 2022 · 5 comments · Fixed by #4723 or #4783

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jan 14, 2022

Summary

The independent time conductor setting (enable/disable) persists when you switch between domain objects (plots)
This incorrectly displays data in independent time when it should be showing data for the global application time.

Expected vs Current Behavior

Independent time conductor should correctly enable/disable based on the domain object being displayed.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Steps to Reproduce

  1. Create 2 plots
  2. View one of the plots and enable independent time conductor.
  3. From the navigation tree, select the other plot
  4. Observe that the independent time conductor shows enabled for the 2nd plot as well, but it should be disabled.

Workaround: Refreshing the page will set the independent time conductor correctly.

Environment

  • Open MCT Version: 1.8.4-snapshot
  • Deployment Type: local, banner
  • OS: Mac
  • Browser: All
@charlesh88
Copy link
Contributor

charlesh88 commented Jan 24, 2022

Testathon 1-24-22: verified NOT fixed.

  1. Enable independent Time Conductor (ITC) in two different objects.
  2. Set the ITC to a bounds different from the main TC, then nav to the second object.

Note that the second object will take up the settings from the first object, but should be maintaining its own settings.

The ITC should persist its settings (preferred) or act in a fully transient manner and disable itself when navved back to. @charlesh88 filed #4772 to cover this.

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 01/24/22. I can confirm that navigating away from a plot with the independent time conductor enabled and modified time bounds results in a reset of the time bounds when navigating back to the plot.

@unlikelyzero unlikelyzero reopened this Jan 24, 2022
@shefalijoshi
Copy link
Contributor Author

shefalijoshi commented Jan 26, 2022

Testing instructions:

  1. Create 3 plots
  2. Enable independent time conductor with different bounds for 2 of the 3 plots
  3. Switch between independent time conductor enabled plots and ensure that the bounds correctly load/persist
  4. Switch between the plot with independent time conductor DISABLED and one of the independent time conductor enabled plots. Ensure that the settings show up and save correctly.
  5. Try other combinations of enabled/disabled independent time conductor in plots.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 1/26/2022

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants