Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image thumbnails should be right-aligned #4847

Closed
2 of 5 tasks
charlesh88 opened this issue Feb 10, 2022 · 4 comments · Fixed by #4934
Closed
2 of 5 tasks

Image thumbnails should be right-aligned #4847

charlesh88 opened this issue Feb 10, 2022 · 4 comments · Fixed by #4934
Assignees
Labels
Milestone

Comments

@charlesh88
Copy link
Contributor

Summary

When the number of image thumbnails is smaller than the available display area, they are being drawn from the left - this is incorrect, and caused confusion during Feb egress testing.

Expected vs Current Behavior

Instead, image thumbs should always be right-aligned, in the same way that data points would be spatially placed in a plot view.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken? Not positive this is a regression, but think we used to do this properly.
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Steps to Reproduce

  1. View an imagery endpoint.
  2. Set the Time Conductor such that the number of available images doesn't fill the thumbs holder.
  3. Observe that image thumbs appear from the left in the thumbs holder.

Environment

  • Open MCT Version: 1.8.4
  • Deployment Type: stable/, testathon/
  • OS: Any
  • Browser: Any
@charlesh88
Copy link
Contributor Author

Super-easy CSS-only change: set .c-imagery__thumbs-wrapper to use flex-direction: row-reverse.

@charlesh88
Copy link
Contributor Author

Ignore the previous comment, which reverses the order of the thumbnails. The right approach is justify-content: flex-end added to '.c-imagery__thumbs-wrapper`.

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 04/25/2022

@charlesh88
Copy link
Contributor Author

charlesh88 commented Apr 25, 2022

Verified fixed Testathon 04-25-22, but see related issue in #4850.

@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants