Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing display layout grid size throws console error #4901

Closed
1 of 5 tasks
shefalijoshi opened this issue Mar 1, 2022 · 4 comments
Closed
1 of 5 tasks

Changing display layout grid size throws console error #4901

shefalijoshi opened this issue Mar 1, 2022 · 4 comments

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Mar 1, 2022

Changing the horizontal or vertical grid size in Display Layout edit properties throws a console error.

Expected vs Current Behavior

No console error should be thrown.

Steps to Reproduce

  1. Create a display layout
  2. Save it
  3. Edit properties for this layout and change the horizontal or vertical grid size px.
  4. Press OK to save the properties.
  5. Observe console error displayed.

Environment

  • Open MCT Version: 2.0.1-SNAPSHOT
  • Deployment Type: local
  • OS: Mac
  • Browser: Firefox

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information

[Vue warn]: Invalid prop: custom validator check failed for prop "gridSize".

found in

---> at src/plugins/displayLayout/components/SubobjectView.vue
at src/plugins/displayLayout/components/DisplayLayout.vue
3 vue.js:581:15
VueJS 22
_onSave webpack-internal:///./src/plugins/formActions/EditPropertiesAction.js:77
_showEditForm webpack-internal:///./src/plugins/formActions/EditPropertiesAction.js:108
invoke webpack-internal:///./src/plugins/formActions/EditPropertiesAction.js:54
onItemClicked webpack-internal:///./src/api/menu/MenuAPI.js:87
VueJS 30
show webpack-internal:///./src/api/menu/menu.js:72

@shefalijoshi
Copy link
Contributor Author

Testing Notes:
Try to change the horizontal and vertical grid size of a display layout.
Ensure no console error is displayed.

@charlesh88
Copy link
Contributor

Testathon 3-17-22: verified fixed.

@unlikelyzero
Copy link
Contributor

Verified Fixed

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants