Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator Status Indicators #5193

Closed
akhenry opened this issue May 12, 2022 · 7 comments · Fixed by #5179, #5368 or akhenry/openmct-yamcs#149
Closed

Operator Status Indicators #5193

akhenry opened this issue May 12, 2022 · 7 comments · Fixed by #5179, #5368 or akhenry/openmct-yamcs#149
Labels
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented May 12, 2022

Implement a system to allow operators to report their operational status (eg. 'go', 'no go', etc.), and a specialist user (eg. a flight director) to set a poll question. This is for scenarios such as critical mission phases and activities where the flight director will query each operator (typically via a voice loop) for a go/no go status.

Design Mockups

Operator Status Widget

Screen Shot 2022-05-18 at 7 24 55 AM

Poll Question Widget

Screen Shot 2022-05-18 at 7 25 12 AM

Select design notes

  • The design utilizes a new Notification widget in the Status bar area; this widget must be aware of the current user's position and role and only allow the correct users to see and interact with it.
  • If the current user doesn't have sufficient permissions, they should not see the Notifier widget at all.
  • Response options will be configurable per deployment in a configuration file.
  • The number of responses should be controllable.
  • Response colors should be settable as hex color values.
  • Response names (Green, Amber, etc.) should be controllable.
  • Response icons should be settable, and optional. These could simply be strings that map to our available glyph classes, like 'icon-check', 'icon-alert-triangle', etc.

Design details are available in Confluence

@akhenry
Copy link
Contributor Author

akhenry commented Jun 2, 2022

Testing Notes

Testing operator status requires at least three people testing at the same time - Two operators, and one Flight Director. These roles will need to be assigned in Yamcs first (@akhenry to do this).

Setup needed

  1. Assign one participant to the Flight Director role in Yamcs
  2. Assign all other participants to an operator role in Yamcs

If you're an operator (Everyone except @charlesh88 )

  1. Verify that the the operator status indicator is available to you. This is where it's located -
    Screen Shot 2022-06-02 at 2 04 18 PM

  2. Verify that the current poll question is shown in your operator status indicator.

  3. Verify that your status is shown in the operator status indicator, and that the status field is not blank.

  4. Verify that you can successfully change your status via the operator status indicator

  5. Verify that the color and icon change appropriately when you change your status. Here are the icons and colors configured in our test environment -
    Screen Shot 2022-06-02 at 2 01 59 PM
    Screen Shot 2022-06-02 at 2 02 10 PM
    Screen Shot 2022-06-02 at 2 02 21 PM

  6. Verify that the current poll question is shown in the operator status indicator

  7. Verify that the poll question is updated in your indicator when the Flight Director changes it (you will need to coordinate with FD)

If you're FD @charlesh88

  1. Verify that the poll question indicator is available to you. It is located here -
    image
  2. Verify that you can change the poll question
  3. Verify that the poll question is automatically updated in Operators' displays when you set a new poll question (you will need to coordinate with operators)
  4. Verify that changing the poll question resets the status of all operators to "NO_STATUS". You will need to coordinate with operators.
  5. Verify that the status counts are correct (you will need to coordinate with operators)
  6. As well as the counts being correct, verify that the colors are correct. In our test environment they should look like this:
    Screen Shot 2022-06-02 at 2 09 27 PM

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jun 9, 2022
@davetsay
Copy link
Contributor

seeing this console error. also not seeing the status indicator changing when I change it, although a notification says it was saved successfully.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'subscribe')
    at k.getPollQuestion (openmct-yamcs.js?e792:1:22409)
    at async a.fetchCurrentPoll (OperatorStatus.vue?a4fd:114:1)
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'subscribe')
    at k.getStatusForRole (openmct-yamcs.js?e792:1:21807)
    at async StatusAPI.getStatusForRole (StatusAPI.js?901b:126:1)
    at async a.fetchMyStatus (OperatorStatus.vue?a4fd:130:1)

@akhenry
Copy link
Contributor Author

akhenry commented Jun 15, 2022

@davetsay Thanks, have filed akhenry/openmct-yamcs#148

@unlikelyzero
Copy link
Contributor

John to write tests along with Andrew

@charlesh88
Copy link
Contributor

charlesh88 commented Jul 6, 2022

Verified PARTIALLY FIXED as admin flight director as Flight Director user role in Testathon 07-06-22.

Problems:

  • @akhenry The admin reporting UI counts sporadically lag behind the telemetry. Create a Op Status LAD Table to watch poll values come in from positions, and compare to numbers shown in the overlay.
  • @akhenry Console errors being thrown on load:

Screen Shot 2022-07-06 at 11 52 24 AM

  • @charlesh88 Tooltips are missing from the admin overlay for the reporting numbers, should show "Unreported", "Go", etc.

@akhenry
Copy link
Contributor Author

akhenry commented Jul 7, 2022

Testing instructions

The admin reporting UI counts sporadically lag behind the telemetry.

Create a Op Status LAD Table to watch poll values come in from positions, and compare to numbers shown in the overlay.

Console errors being thrown on load

Verify that no console errors appear on first load of the application.

@charlesh88
Copy link
Contributor

charlesh88 commented Jul 8, 2022

Testathon 07-08-22: verified fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants