Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imagery Layers] NIRVSSOMCT-271 Placeholder #5324

Closed
unlikelyzero opened this issue Jun 9, 2022 · 9 comments
Closed

[Imagery Layers] NIRVSSOMCT-271 Placeholder #5324

unlikelyzero opened this issue Jun 9, 2022 · 9 comments

Comments

@unlikelyzero
Copy link
Contributor

unlikelyzero commented Jun 9, 2022

Placeholder for NIRVSSOMCT-271

Using Example Imagery or an imagery endpoint, verify the following:

A layers menu button with dropdown appears. 

Checking and unchecking layers hides layers as expected.

@charlesh88
Copy link
Contributor

charlesh88 commented Jun 15, 2022

Verified NOT fixed Testathon 06-15-22: example imagery is not displaying layer art properly (source URLs were 404ing from /testathon).

The dropdown palette layout is also broken:
image

image

@charlesh88 Will add testing notes once a fix is in and screen caps can be included.

@charlesh88 charlesh88 reopened this Jun 15, 2022
@charlesh88 charlesh88 self-assigned this Jun 15, 2022
@charlesh88
Copy link
Contributor

charlesh88 commented Jul 11, 2022

Testathon 07-11-22: verified NOT fixed, same problem as before with layer art not being displayed and throwing 404 errors in the console.

@unlikelyzero
Copy link
Contributor Author

We will need to address this feature as a new, untested feature in 2.1.0

@akhenry
Copy link
Contributor

akhenry commented Aug 7, 2022

This is because the example images are not being copied into the deployment directory. The issue is, they shouldn't be deployed into production environments, and we certainly should not have any configuration in a production environment that copies them into the deployment directory.

One option here might be to host the example overlays from our public webserver (github pages) so they're accessible from anywhere with no deployment-specific configuration.

@wbnns
Copy link

wbnns commented Aug 8, 2022

One option here might be to host the example overlays from our public webserver (github pages) so they're accessible from anywhere with no deployment-specific configuration.

If helpful, you could also/alternatively set up an openmct-assets repository and direct link to the resources there, and utilize similarly to as if it were like an S3 bucket.

@akhenry
Copy link
Contributor

akhenry commented Aug 12, 2022

@wbnns That's a great, suggestion, thank you!

@akhenry
Copy link
Contributor

akhenry commented Aug 12, 2022

Testing Instructions

This can only be verified locally.

  1. Navigate to an example imagery telemetry point
  2. Verify that a layers menu button with dropdown appears.
  3. Verify that checking and unchecking layers hides layers as expected.

@akhenry
Copy link
Contributor

akhenry commented Aug 12, 2022

VIPERRQSTS-203 describes a new "grid overlay" specifically for the viper-openmct project which will allows this to be verified in that environment.

@shefalijoshi
Copy link
Contributor

Verified fixed locally.

@unlikelyzero unlikelyzero added this to the Target:2.0.8 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants