Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on a search entry does not navigate to entry in tree #5439

Closed
2 of 7 tasks
davetsay opened this issue Jul 6, 2022 · 6 comments · Fixed by #5483
Closed
2 of 7 tasks

Clicking on a search entry does not navigate to entry in tree #5439

davetsay opened this issue Jul 6, 2022 · 6 comments · Fixed by #5483
Labels
bug:regression It used to work. Now it doesn't :( needs:e2e Needs an e2e test severity:critical type:bug
Milestone

Comments

@davetsay
Copy link
Contributor

davetsay commented Jul 6, 2022

Summary

Clicking on a search entry displays the object, displays the correct inspector view(s), but does not highlight the object in the tree.

Fix should be in router, or search not using router properly.

Expected vs Current Behavior

The object should be selected in tree.

Steps to Reproduce

  1. use search bar to search for an existing object
  2. click on a valid search entry
  3. observe that the object is displayed in the main view and the inspector view
  4. click on the target icon show selected item in tree
  5. observe object is not navigated to when it should

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@akhenry
Copy link
Contributor

akhenry commented Jul 8, 2022

This may relate to #5469. Search results appear to have incorrect contextual paths.

@michaelrogers
Copy link
Contributor

Fix verified in testathon 07/12/2022.

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jul 12, 2022

Fixed - Click on the VIPER dictionary, then type 'analog' in the search box. Click on one of the search results. The telemetry endpoint is displayed. Refreshing the browser after that also takes me to the 'analog' endpoint.
This is the expected behavior, so we're good.

@akhenry
Copy link
Contributor

akhenry commented Jul 12, 2022

Verified Fixed

@jvigliotta
Copy link
Contributor

Verified Fixed: Testathon 7/12/22

@ozyx
Copy link
Contributor

ozyx commented Jul 12, 2022

Verified 7/12/22 Testathon.

Searched for an entry, clicked on it, and was able to refresh and be navigated back to the same object (URL updates accordingly). The entry in the tree is highlighted briefly if already scrolled into view.

Caveat:
The tree does not scroll to the selected object. The tree does not expand paths leading to the selected object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( needs:e2e Needs an e2e test severity:critical type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants