Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy stacked plot interceptor should be renamed for clarity #5463

Closed
davetsay opened this issue Jul 8, 2022 · 4 comments
Closed

Legacy stacked plot interceptor should be renamed for clarity #5463

davetsay opened this issue Jul 8, 2022 · 4 comments
Labels
help_wanted Help the Open MCT project! needs:e2e Needs an e2e test type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.6

Comments

@davetsay
Copy link
Contributor

davetsay commented Jul 8, 2022

Summary

see #5422 for relevant code to rename
@davetsay davetsay added type:maintenance tests, chores, or project maintenance help_wanted Help the Open MCT project! labels Jul 8, 2022
@alizenguyen alizenguyen self-assigned this Jul 8, 2022
@alizenguyen alizenguyen mentioned this issue Jul 8, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero added the needs:test instructions Missing testing notes label Jul 11, 2022
@unlikelyzero
Copy link
Contributor

Needs updated test instructions

@alizenguyen
Copy link
Contributor

alizenguyen commented Jul 11, 2022 •
edited
Loading

To Test:

Navigate to a plot object created before #5198 was merged in. No console errors should appear when viewing.

Look for any regressions from this fix #5420.

@ozyx
Copy link
Contributor

ozyx commented Jul 11, 2022

Verified 7/11/22 Testathon:

Navigated to very old 1.7.8 stacked plot and saw no console errors.

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jul 11, 2022
@unlikelyzero
Copy link
Contributor

unlikelyzero commented Jul 11, 2022 •
edited
Loading

e2e testing notes

  • Generate a Plot from Build 5 and store in ./e2e/tests/test-data
  • Write a new testsuite in ./e2e/tests/migrations.e2e.spec.js
  • Write a test which imports a Plot from Build 5, adds a new example Telemetry Source, and Deletes the object. No errors thrown

@unlikelyzero unlikelyzero removed unverified help_wanted Help the Open MCT project! labels Jul 11, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@unlikelyzero unlikelyzero added help_wanted Help the Open MCT project! and removed needs:test instructions Missing testing notes labels Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help_wanted Help the Open MCT project! needs:e2e Needs an e2e test type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.6
Development

No branches or pull requests
5 participants
@davetsay @akhenry @ozyx @unlikelyzero @alizenguyen