Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribute node.js client #5

Closed
Reid00 opened this issue Nov 29, 2021 · 6 comments
Closed

contribute node.js client #5

Reid00 opened this issue Nov 29, 2021 · 6 comments

Comments

@Reid00
Copy link

Reid00 commented Nov 29, 2021

we do some second-dev on this project for Node client, it has been run for months in prod. we plan to donate it with new branch or other someway else you need, what process should us follow? this one https://docs.nebula-graph.com.cn/2.6.1/15.contribution/how-to-contribute/?

@wey-gu
Copy link
Member

wey-gu commented Nov 29, 2021

Amazing, @Reid00 thanks so much,

Could you please help put non-code design in an issue, and push code in PR?

It would be better that could be phased in several PRs while it's already squashed, you could put all changes in one PR.

Thanks!

@Reid00
Copy link
Author

Reid00 commented Nov 29, 2021

Got it, talked with my colleague, will do it later.

@wey-gu
Copy link
Member

wey-gu commented Dec 1, 2021

I wonder if it's possible to put the follow-up efforts as a nebula hackathon project?
@Reid00 @QingZ11

@Reid00
Copy link
Author

Reid00 commented Dec 1, 2021

talked with my colleague we think it's great.

@wey-gu
Copy link
Member

wey-gu commented Dec 2, 2021

talked with my colleague we think it's great.

Saw your team 🤘🏻, 加油!

@wey-gu
Copy link
Member

wey-gu commented Dec 22, 2021

#6 was merged, thanks a ton to @wujjpp @Reid00 for the great work and @nianiaJR for the reviewing! 🎉

@wujjpp wujjpp closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants