Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neonvm-daemon: store fractional value in the neonvm-daemon #1243

Open
mikhail-sakhnov opened this issue Feb 4, 2025 · 1 comment
Open

neonvm-daemon: store fractional value in the neonvm-daemon #1243

mikhail-sakhnov opened this issue Feb 4, 2025 · 1 comment
Labels
a/tech_debt Area: related to tech debt c/autoscaling/neonvm Component: autoscaling: NeonVM

Comments

@mikhail-sakhnov
Copy link
Contributor

mikhail-sakhnov commented Feb 4, 2025

We currently never use neonvm-daemon /cpu GET endpoint, since it has no support for fractional CPU limits. Instead we rely on the value stored in the runner memory via atomic variable, which is updated on each scaling request.

As a first step for fractional limits, we might want to move that variable into the neonvm-daemon.

Reasons:

  • as said, first step towards proper fractional limits
  • clearer ownership - all cpu related state will be kept in a single component (neonvm-daemon) rather than in 2 components as now (neonvm-daemon, neonvm-runner)

Context:
Discussion in #1190 (comment)_

@sharnoff sharnoff added c/autoscaling/neonvm Component: autoscaling: NeonVM a/tech_debt Area: related to tech debt labels Feb 4, 2025
@sharnoff
Copy link
Member

sharnoff commented Feb 4, 2025

This should also be a dependency for #850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/autoscaling/neonvm Component: autoscaling: NeonVM
Projects
None yet
Development

No branches or pull requests

2 participants