Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql federation code/schema examples are not correct #14676

Open
1 of 15 tasks
dberardo-com opened this issue Feb 21, 2025 · 0 comments
Open
1 of 15 tasks

graphql federation code/schema examples are not correct #14676

dberardo-com opened this issue Feb 21, 2025 · 0 comments
Labels
needs triage This issue has not been looked into

Comments

@dberardo-com
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

the example should not be using introspectAndCompose which is not production ready. they should be using auto generated typings files, like in the doc: https://docs.nestjs.com/graphql/federation#schema-first-1

even better would be if the schema first example was showing a way to generate the .gql schema files from an npm run command and both the schema-first and the code-first had an example of how to merge the schemas into a single file in the gateway folder, perhaps using the generate-typings script: https://docs.nestjs.com/graphql/quick-start#schema-first

Minimum reproduction code

no

Steps to reproduce

No response

Expected behavior

no

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

No response

Packages versions

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@dberardo-com dberardo-com added the needs triage This issue has not been looked into label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

1 participant