Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event svg header picture has a "nodata" title when using default picture #1593

Closed
tcitworld opened this issue Oct 26, 2019 · 8 comments · Fixed by #1609
Closed

Event svg header picture has a "nodata" title when using default picture #1593

tcitworld opened this issue Oct 26, 2019 · 8 comments · Fixed by #1609
Labels
Milestone

Comments

@tcitworld
Copy link
Member

And it shows when hovering over the picture.

@tcitworld tcitworld added 1. to develop Accepted and waiting to be taken care of bug Feature: Editor labels Oct 26, 2019
@georgehrke
Copy link
Member

Should we set a different title or remove all titles from all SVGs?

@tcitworld
Copy link
Member Author

I think it's still useful for a11y to have a title on the picture, but I'm not sure how to handle the default one (change the nodata value or remove it in this particular case).
Maybe @nextcloud/accessibility could help?

@georgehrke
Copy link
Member

If we decide to keep a title for the illustration, we end up with the next problem that the titles are hardcoded in the svg and not translatable

@skjnldsv
Copy link
Member

skjnldsv commented Oct 26, 2019

css and hide it?
or does it says on a browser's tooltip? Like an alt or title?

@georgehrke
Copy link
Member

Yes, browser tooltip, not v-tooltip.

@georgehrke
Copy link
Member

And if we want to keep it for accessibility, "No data" and all the other titles are not exactly meaningful. It should describe the actual content, like "Illustration of event: Two empty clipboards"

@georgehrke
Copy link
Member

Current proposal: Keep this issue open to tackle it in the long run, remove the current titles, because they don't add any meaningful value.

@tcitworld @skjnldsv Any objections? :)

@georgehrke georgehrke added this to the 2.0.0 beta2 milestone Oct 28, 2019
@georgehrke
Copy link
Member

Pull request: #1609
Follow up ticket: #1610

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants