Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working out should recognise "Gym" as event title. #1888

Closed
rspencer01 opened this issue Jan 23, 2020 · 5 comments · Fixed by #1910
Closed

Working out should recognise "Gym" as event title. #1888

rspencer01 opened this issue Jan 23, 2020 · 5 comments · Fixed by #1910
Labels
0. to triage Pending approval or rejection

Comments

@rspencer01
Copy link
Contributor

Describe the solution you'd like
Events titled "gym" to have illustration relating to working out.

Additional context
Requires a single line addition to


and possibly some localization.

@rspencer01 rspencer01 added 0. to triage Pending approval or rejection enhancement-proposed labels Jan 23, 2020
@georgehrke
Copy link
Member

@rspencer01 Would you mind just sending a pull-request since you already found the right line of code? :)

@rspencer01
Copy link
Contributor Author

rspencer01 commented Jan 23, 2020 via email

@SuperSandro2000
Copy link

Would this mark Gymnasium which is the German word for high school?

@rspencer01
Copy link
Contributor Author

This is already a problem with English events such as Campaign for Better String Matching giving the camping image. My suggestion would be to match space delineated words, which brings in trouble with multi-word matches and hyphens and the like and warrants a separate issue really.

@georgehrke
Copy link
Member

warrants a separate issue really

yes, we need a better matching. To only match for actual words only, not words containing other words. Something like (?<![\w\d])abc(?![\w\d])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. to triage Pending approval or rejection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants