-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working out should recognise "Gym" as event title. #1888
Comments
@rspencer01 Would you mind just sending a pull-request since you already found the right line of code? :) |
Can do. Will only get round to it later when I'm not at work, but thought I'd drop this here is in case some kind soul got to it faster.
|
Would this mark |
This is already a problem with English events such as Campaign for Better String Matching giving the camping image. My suggestion would be to match space delineated words, which brings in trouble with multi-word matches and hyphens and the like and warrants a separate issue really. |
yes, we need a better matching. To only match for actual words only, not words containing other words. Something like |
Describe the solution you'd like
Events titled "gym" to have illustration relating to working out.
Additional context
Requires a single line addition to
calendar/src/utils/illustration.js
Line 365 in 85e9f76
and possibly some localization.
The text was updated successfully, but these errors were encountered: