Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show proper emptycontent view for non-existing public calendar links #240

Closed
jancborchardt opened this issue Dec 15, 2016 · 2 comments · Fixed by #372
Closed

Show proper emptycontent view for non-existing public calendar links #240

jancborchardt opened this issue Dec 15, 2016 · 2 comments · Fixed by #372
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. Feature: Sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone
1.5.4-current-mai...

Comments

@jancborchardt
Copy link
Member

Currently when you go to https://cloud.nextcloud.com/apps/calendar/public/non-existing-calendar there’s just an empty calendar. This calendar does not actually exist and there should be indication of that. Instead of the calendar view on the right, there should be an emptycontent-like view similar to the Files app for empty folders. :)

Saying something like:

[icon-calendar]
Calendar does not exist
Maybe the link is wrong?

cc @nextcloud/calendar
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of bug design Related to design, interface, interaction design, UX, etc. Feature: Sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Dec 15, 2016
@georgehrke
Copy link
Member

Hm, definitely a good point, but I think we should go with an overlay.
The problem here is, that the php side of the calendar app can't determine whether or not a calendar exists. We first have to send a request to the CalDAV server to then see: Oh, it's a 404

@georgehrke georgehrke added this to the 1.6.0-next milestone Dec 15, 2016
@jancborchardt
Copy link
Member Author

Yup, overlay is fine too. :) The important thing is that the basic style of the emptycontent is used, and there is actual feedback.

@georgehrke georgehrke mentioned this issue Mar 20, 2017
Merged
@georgehrke georgehrke added 2. developing Work in progress 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress labels Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. Feature: Sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
1.5.4-current-maintenance
Development

Successfully merging a pull request may close this issue.

Public sharing improvements nextcloud/calendar
2 participants
@jancborchardt @georgehrke