fixes #24641; quote do captures no variables without backticks
#24642
+22
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
changed the title
quote do captures no variables under current macrosquote do captures no variables without backticks under current macros
|
related to #8574 |
ringabout
changed the title
quote do captures no variables without backticks under current macrosquote do captures no variables without backticks
|
It allows top level syms to be captured for backwards compatibility, but still benefits from not capturing local varibles in macros/procs result = quote do:
initFromJson(`baseTyp`(`dst`), `jsonNode`, `jsonPath`)This is wrong because |
ringabout
commented
Jan 24, 2025
|
The latest changes skip the current owner scope if the kind of owner belongs to routine kinds |
|
Has the potential to break somebody's subtle macro trickery. Not sure what to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24641
ref #17426
TODO:
This PR solves problems in nim-lang/RFCs#122
The quoted ast won't capture local variables from macros anymore. It solves #7323 which is a special case of capturing
result. Then we can revert #7343 that did some hack onresult.