Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Picker idea - git diff #2792

Closed
ColinKennedy opened this issue Nov 19, 2023 · 3 comments
Closed

New Picker idea - git diff #2792

ColinKennedy opened this issue Nov 19, 2023 · 3 comments
Labels
enhancement Enhancement to performance, inner workings or existent features

Comments

@ColinKennedy
Copy link

Is your feature request related to a problem? Please describe.
I recently learned of git jump and it's awesome. Using some simple lua + hydra.nvim I've effectively replicated a git add -p but unlike that view, which is read-only and can only advance in one direction, Neovim buffers are editable so if a line isn't quite right, I can modify the lines, head to another file, and do whatever I need just before staging them. It makes adding/committing a lot easier.

git_add_p_hydra_demo.mp4

Anyway, the whole thing is quickfix driven, which made me think of Telescope. I was wondering if folks would be interested in contributing this back, as a basic file+line number picker.

@ColinKennedy ColinKennedy added the enhancement Enhancement to performance, inner workings or existent features label Nov 19, 2023
@jamestrew
Copy link
Contributor

Thanks for reaching out but unfortunately, I don't think we're adding new pickers to telescope at the moment without significant interest from one of the maintainers (see #1228 for more context).

For any new pickers, we encourage users to create them as telescope extensions. https://github.com/nvim-telescope/telescope.nvim/blob/master/developers.md

@ColinKennedy
Copy link
Author

I was unclear in my earlier message. What I meant was "If I made an extension, would you consider it useful + would like to add it to https://github.com/nvim-telescope/telescope.nvim/wiki/Extensions"?

@jamestrew
Copy link
Contributor

@ColinKennedy oh yes of course. That'll be awesome.
I'll mark this as closed but feel free to ask questions if you have any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to performance, inner workings or existent features
Projects
None yet
Development

No branches or pull requests

2 participants