Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hardforks): Isthmus Network Upgrade Transactions #1080

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(hardforks): Isthmus Network Upgrade Transactions #1080

wants to merge 1 commit into from

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Feb 21, 2025

Description

Adds L1 Block Info Txs for the operator fee vault activated at the Isthmus hardfork.

Closes #1079

@refcell refcell added K-chore Kind: chore A-protocol Area: protocol crates H-isthmus Hardfork: Isthmus related labels Feb 21, 2025
@refcell refcell self-assigned this Feb 21, 2025
@refcell refcell changed the title isthmus: network upgrade transactions feat(hardforks): Isthmus Network Upgrade Transactions Feb 21, 2025
@refcell refcell added K-feature Kind: feature and removed K-chore Kind: chore labels Feb 21, 2025
@refcell refcell mentioned this pull request Feb 21, 2025
Closed
refcell
refcell commented Feb 21, 2025
View reviewed changes
crates/protocol/hardforks/src/bytecode/gpo_isthmus.hex
@@ -0,0 +1 @@
TODO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From: https://github.com/ethereum-optimism/specs/blob/main/specs/static/bytecode/isthmus-gas-price-oracle-deployment.txt

refcell
refcell commented Feb 21, 2025
View reviewed changes
crates/protocol/hardforks/src/bytecode/l1_block_isthmus.hex
@@ -0,0 +1 @@
TODO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From: https://github.com/ethereum-optimism/specs/blob/main/specs/static/bytecode/isthmus-l1-block-deployment.txt

refcell
refcell commented Feb 21, 2025
View reviewed changes
crates/protocol/hardforks/src/bytecode/ofv_isthmus.hex
@@ -0,0 +1 @@
TODO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From: https://github.com/ethereum-optimism/specs/blob/main/specs/static/bytecode/isthmus-operator-fee-deployment.txt

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
342 1 341 0
View the top 1 failed test(s) by shortest run time 
kona-hardforks forks::tests::test_hardforks
Stack Traces | 0.03s run time 
thread 'forks::tests::test_hardforks' panicked at .../hardforks/src/isthmus.rs:117:14:
Expected hex byte string: InvalidHexCharacter { c: 'T', index: 0 }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby Awaiting requested review from clabby clabby will be requested when the pull request is marked ready for review clabby is a code owner

@emhane emhane Awaiting requested review from emhane emhane will be requested when the pull request is marked ready for review emhane is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@refcell refcell

Labels
A-protocol Area: protocol crates H-isthmus Hardfork: Isthmus related K-feature Kind: feature
Projects
Project Tracking
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Fill in Operator Fee Network Upgrade Transaction Bytecodes
1 participant
@refcell