Application configuration files should be moved out of the /etc directory.

[i5okie]

Application files should be moved out of the /etc directory.

acapy-vc-authn-oidc/charts/vc-authn-oidc/templates/deployment.yaml

Lines 73 to 76 in dc46e70

	- name: CONTROLLER_SESSION_TIMEOUT_CONFIG_FILE
	value: /etc/controller-config/sessiontimeout.json
	- name: CONTROLLER_VARIABLE_SUBSTITUTION_OVERRIDE
	value: /etc/controller-config/user_variable_substitution.py

/etc directory is a system directory and contains configuration files for the operating system.
Placing web application files in the /etc directory introduces a security risk.

Relocating these files to /app/config would be more appropriate.

[loneil]

Note the /app directory root is the source. Not sure if confusing or anything to have source and configmap'd config in the same root?

Would this be a better setup? I don't know what do people think (maybe not a big deal having deployed source code to same root folder as these config files)

/app
|-- /controller-config
|   |-- user_variable_substitution.py 
|   |-- sessiontimeout.json 
|   |-- /templates
|-- /src
|   |-- main.py
|   |-- app.py blah blah

Also not sure what the current deal with the existing config folder is with the symlinks and ..data and dated folder? Normal for volume mount or configmap setup??

[esune]

Unsure about the symlinks, but think you're right and they are a byproduct of the mounted configmap.

Regarding the configuration folder: I do like the structure you propose: it doesn't make too big of a difference technically, but it provides some good logical separation of code from configurable assets.