Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exact gasUsed for eth_createAccessList #10416

Closed
mattsse opened this issue Aug 21, 2024 · 1 comment
Closed

Return exact gasUsed for eth_createAccessList #10416

mattsse opened this issue Aug 21, 2024 · 1 comment
Assignees
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 21, 2024

Describe the feature

currently we're failing eth_getTransactionReceipt/get-access-list:

https://hivetests2.ethdevops.io/suite.html?suiteid=1724234283-97d383360f6fb3acb2dcc0e447b02aca.json&suitename=rpc-compat#test-22

due to a gasUsed mismatch

gasUsed: A hexadecimal string representing the approximate gas cost for the transaction if the access list is included.

the issue is likely this estimate call:

let gas_used =
self.estimate_gas_with(cfg_with_spec_id, env.block.clone(), request, &*db.db, None)?;

which isn't gasUsed but estimates gas

TODO

  • change this estimate call to another transact call with the set accessList of the txEnv after tracing, similar to:

let (result, env) = self.inspect(&mut db, env, &mut inspector)?;

but with self.transact after setting env.txEnv.accessList

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Aug 21, 2024
@malik672
Copy link
Contributor

@mattsse assign me

@emhane emhane added A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code C-bug An unexpected or incorrect behavior and removed C-enhancement New feature or request C-debt A clean up/refactor of existing code labels Aug 21, 2024
@mattsse mattsse closed this as completed Aug 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

No branches or pull requests

3 participants